Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor gaming-setup.sh #380

Merged
merged 5 commits into from
Sep 18, 2024
Merged

Refactor gaming-setup.sh #380

merged 5 commits into from
Sep 18, 2024

Conversation

adamperkowski
Copy link
Collaborator

@adamperkowski adamperkowski commented Sep 14, 2024 •
edited
Loading

Type of Change

  • Refactoring

Description

Refactored the gaming setup script to have more synergy with other scripts, removed bashisms, updated dep list and added new features (for package managers).

Impact

  • revieved all packages
  • changed the structure to have synergy with other scripts
  • updated dnf & zypper commands
  • added nala

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no errors/warnings/merge conflicts.

@adamperkowski
Refactored + removed bashisms
27941db 
 - revieved all packages
 - changed the structure to have synergy with other scripts
 - updated dnf & zypper commands
 - added nala
nnyyxxxx
nnyyxxxx approved these changes Sep 14, 2024
View reviewed changes
Copy link
Contributor

@nnyyxxxx nnyyxxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@nnyyxxxx nnyyxxxx mentioned this pull request Sep 15, 2024
Closed
7 tasks
@nnyyxxxx nnyyxxxx mentioned this pull request Sep 17, 2024
Merged
6 tasks
adamperkowski and others added 2 commits September 17, 2024 13:45
@nnyyxxxx nnyyxxxx mentioned this pull request Sep 17, 2024
Closed
5 tasks
@jeevithakannan2 jeevithakannan2 mentioned this pull request Sep 17, 2024
Merged
5 tasks
@adamperkowski
Copy link
Collaborator Author

Not sure what's up with the CI here.

This was referenced Sep 17, 2024
Closed
Closed
Merged
@ChrisTitusTech ChrisTitusTech merged commit 44d9360 into ChrisTitusTech:main Sep 18, 2024
1 check failed
@adamperkowski adamperkowski deleted the gaming_setup_refactor branch September 18, 2024 20:16
@ChrisTitusTech ChrisTitusTech added the bug Something isn't working label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnyyxxxx nnyyxxxx nnyyxxxx approved these changes

@ChrisTitusTech ChrisTitusTech ChrisTitusTech approved these changes

Assignees
No one assigned
Labels
bug Something isn't working refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamperkowski @ChrisTitusTech @nnyyxxxx